SforAiDl / jeta

A Jax based meta learning library
MIT License
16 stars 12 forks source link

Add tests #37

Closed Riddhi2587 closed 2 years ago

Riddhi2587 commented 2 years ago

Tests for maml and optimization trainer

veds12 commented 2 years ago

@Riddhi2587 please run the pre-commit before pushing: https://github.com/SforAiDl/jeta/blob/main/CONTRIBUTING.md

abhi-glitchhg commented 2 years ago

@Riddhi2587, Were you trying to update your branch with the new changes? If yes, git force is not a proper way to do it.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@veds12, can you check with repository settings if the following option is available? Always suggest updating pull request branches. updating branches would be more easy.

veds12 commented 2 years ago

@abhi-glitchhg Yeah she did it by mistake. Luckily the the commit was empty. I have disabled pushing to the main repo directly (requires permit from one of the maintainers after an approved review)

abhi-glitchhg commented 2 years ago

I have disabled pushing to the main repo directly (requires a permit from one of the maintainers after an approved review)

Nice.

But I was suggesting a different thing; If you enable it; collaborators and maintainers can easily update the branches. here's github documentation of the feature.

IMO it is a good to have in this repo as well.

if there is conflict it shows up there as well.

(reference image) image