Closed abhi-glitchhg closed 2 years ago
I guess we can do this for all packages. What do you think?
I guess we can do this for all packages. What do you think?
I did not do it for all other libraries because if some library scraps any feature used in the Vformer, then it might be an issue; That's my concern.
But Not blocking from my side.
Yeah, that's true. But I think we can do it for all major packages. So apart from torch and torchvision, could you make the changes for Pytest and OpenCV as well? Then we can merge this.
Actually, I think we can remove OpenCV from the requirements. It's only there because it is being used in the example script for visualization. I don't think we need to have it as a dependency for the package. So, I guess you can just make the change for Pytest and then we can merge this.
Actually, I think we can remove OpenCV from the requirements. It's only there because it is being used in the example script for visualization. I don't think we need to have it as a dependency for the package. So, I guess you can just make the change for Pytest and then we can merge this.
Yeah, I agree! I had thought about removing OpenCV as a dependency
Yeah, that's true. But I think we can do it for all major packages. So apart from torch and torchvision, could you make the changes for Pytest and OpenCV as well? Then we can merge this.
agree. 👍
Codecov Report