SforAiDl / vformer

A modular PyTorch library for vision transformer models
https://vformer.readthedocs.io/
MIT License
162 stars 22 forks source link

Relax version constraints for Torch, Torchvision, and Pytest dependencies #84

Closed abhi-glitchhg closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #84 (9346910) into main (ec7238f) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         1872      1872           
=========================================
  Hits          1872      1872           
NeelayS commented 2 years ago

I guess we can do this for all packages. What do you think?

abhi-glitchhg commented 2 years ago

I guess we can do this for all packages. What do you think?

I did not do it for all other libraries because if some library scraps any feature used in the Vformer, then it might be an issue; That's my concern.

But Not blocking from my side.

NeelayS commented 2 years ago

Yeah, that's true. But I think we can do it for all major packages. So apart from torch and torchvision, could you make the changes for Pytest and OpenCV as well? Then we can merge this.

NeelayS commented 2 years ago

Actually, I think we can remove OpenCV from the requirements. It's only there because it is being used in the example script for visualization. I don't think we need to have it as a dependency for the package. So, I guess you can just make the change for Pytest and then we can merge this.

abhi-glitchhg commented 2 years ago

Actually, I think we can remove OpenCV from the requirements. It's only there because it is being used in the example script for visualization. I don't think we need to have it as a dependency for the package. So, I guess you can just make the change for Pytest and then we can merge this.

Yeah, I agree! I had thought about removing OpenCV as a dependency

abhi-glitchhg commented 2 years ago

Yeah, that's true. But I think we can do it for all major packages. So apart from torch and torchvision, could you make the changes for Pytest and OpenCV as well? Then we can merge this.

agree. 👍