Sgt-Imalas / Sgt_Imalas-Oni-Mods

All the ONI mods made by Sgt_Imalas
MIT License
21 stars 8 forks source link

[BUG]: crashes on world gen #48

Closed rrnk235 closed 1 year ago

rrnk235 commented 1 year ago

Description of the bug/crash

crashes when i try to generate a world idk which file to send so ima send both

Steps To Reproduce

tried to generate a normal world with large glacier frozen core geodes metal rich and geoactive it is the only mod i had instlled on my last attempt

Player.log

Player.log Player-prev.log

rrnk235 commented 1 year ago

ok got it now what lol just run it till it crashes?

Sgt-Imalas commented 1 year ago

With that mod enabled, yes

rrnk235 commented 1 year ago

ok done now what?

Sgt-Imalas commented 1 year ago

log please

rrnk235 commented 1 year ago

playerlog?

Sgt-Imalas commented 1 year ago

yes

rrnk235 commented 1 year ago

Player.log

rrnk235 commented 1 year ago

i wish i could understand it lol im reading it kinda seeing where the error starts but dont understand it after that lol youre a mad man XD

Sgt-Imalas commented 1 year ago

its even more wtf. this is the method in question: public void NewSaveGamePrefab() { if (prefab_NewSaveGame != null && SaveGame.Instance == null) { Util.KInstantiate(prefab_NewSaveGame, base.gameObject); } } I check if either prefab_NewSaveGame or base.gameObject exist - both exist yet the crash still says "one of them doesnt exist" w t f

rrnk235 commented 1 year ago

wtf i kinda understood that lol

rrnk235 commented 1 year ago

i was wayoff what i thought the prob was

Sgt-Imalas commented 1 year ago

it also crashes after the vanilla world gen was successful (If you start it via the normal button, I dont modify the worldgen at all) so after that has been (I might add: successfully) run, it crashes

rrnk235 commented 1 year ago

thats what i did last time and it crashed

rrnk235 commented 1 year ago

ohh somthing new

Sgt-Imalas commented 1 year ago

I know (I have detailed logging added to the log if the cluster is custom generated)

but something else causes that crash (but it still seems to be linked to the mod in some way)

rrnk235 commented 1 year ago

image

Sgt-Imalas commented 1 year ago

thats just a regular worldgen failure (normally that would be a "couldnt germinate" message, I adjusted that)

do you have other savegames?

rrnk235 commented 1 year ago

yes i do

rrnk235 commented 1 year ago

a couple over the years lol

rrnk235 commented 1 year ago

there my well lets just say doomed colonies lol

Sgt-Imalas commented 1 year ago

ok

rrnk235 commented 1 year ago

seems like i can load up myold save

rrnk235 commented 1 year ago

ok so it gets weirder

rrnk235 commented 1 year ago

i load in on no sweat nd it works just fine its broken on survival

rrnk235 commented 1 year ago

yea works every time on no sweat

Sgt-Imalas commented 1 year ago

generating a custom cluster on no sweat works?

rrnk235 commented 1 year ago

or its just magically working

rrnk235 commented 1 year ago

somehow idk what idk why but its generating simple clusters lemme add geodes and all see if i break it

rrnk235 commented 1 year ago

sooooo it works now XD

Sgt-Imalas commented 1 year ago

the generation itself isn't directly related to the crash, if it works, it should work

rrnk235 commented 1 year ago

lemme enable some mods andhope

Sgt-Imalas commented 1 year ago

did it start working after you loaded another savegame?

rrnk235 commented 1 year ago

i beleive so

rrnk235 commented 1 year ago

yes i even enabledmods still works

rrnk235 commented 1 year ago

tysm i asppreciate youre time more than you know youre amazing

Sgt-Imalas commented 1 year ago

great.

I strongly assume that this is some sort of base game bug that only ALMOST crashes in base game, but crashes with my mod enabled. If I got that correctly, loading a savegame before may eliminates it

rrnk235 commented 1 year ago

probably i havent playedit in a while to the point most of my save files are now broken so ima keep thos og save files feels like i have a relic lol

Sgt-Imalas commented 1 year ago

but it is likely dependant on external factors like system speed, hard drive speed, etc, a "magical" bug (hence why I couldn't reproduce it) sadly oni is littered by such issues, these are often race conditions - 2 components start up at the same time, and the game just assumes that one is ready when the other needs it - if that doesnt happens (such as here) - crash

Sgt-Imalas commented 1 year ago

Ill close this issue, if it happens again, try redoing the things you've done here (such as loading a savegame), that will likely fix it again

Sgt-Imalas commented 1 year ago

(you could leave a comment on steam, indicating that the crash was fixed)

rrnk235 commented 1 year ago

i will deff do that and the solution if somone comes across it

Sgt-Imalas commented 1 year ago

just the fixed part is enough, I'll update the description tomorrow, explaining the bug and how to circumvent it (Ill be also looking into options to initialize that mysterious missing component earlier to circumvent the issue)

rrnk235 commented 1 year ago

well i really hope the info helps if you need anything else contact me on steam its the same name as on here i dont use github much so its unlikley ill check it

rrnk235 commented 1 year ago

also mod sugesstion in the mod that changes dupes stats at start would it be viable to be able to remove negatives entirly just food for thought