ShPelles / electron-schematics

Electron extensions for Angular Schematics
7 stars 3 forks source link

Allow us to set electron and electron-builder version #28

Open pontusr opened 5 years ago

pontusr commented 5 years ago

Thanks for these excellent schematics 🥇

It works great - however, we probably need to move to Electron 4 very soon and we would very much need a newer version of electron-builder already now.

Any plans for upgrading or alternatively, allowing us to configure these dependencies separately?

pontusr commented 5 years ago

My mistake on the electron version - I see how I can set this myself. However - we also need to update the electron-builder version and it would be great to either have this updated or configurable.

ShPelles commented 5 years ago

Sorry to disappoint you, but in the current version, I don't see how to update them. Upgrading the electron in your project (in package.json) will not affect the result.

I will check the ability to move these dependencies to peerDependencies, which will enable you to update them in your project's package.json.

chadbr commented 5 years ago

fwiw, I've made a version locally where I upgraded everything to the latest (v6 alpha, latest Angular, etc...) -- but I haven't had a chance to try it out yet.

I could push to a fork if it helps?

Thanks, Chad

pontusr commented 5 years ago

I've also updated all to latest non-alpha/beta dependencies in my local fork - works fine here.