search

ShaMan123 / react-native-math-view

Math view for react native! No WebView!
https://github.com/ShaMan123/react-native-math-view
MIT License
77 stars 24 forks source link

Removed 'assets' field in react-native.config.js #87

Closed rrr3da closed 1 year ago

rrr3da commented 1 year ago

closes #86

ShaMan123 commented 1 year ago

Can you confirm it builds as expected on both ios and android?

rrr3da commented 1 year ago

Well, I just removed an empty array from the configuration... Same thing was done on other third party RN packages to remove the warning message.

What should I do to build the plugin? Is there any specific command I should run?

ShaMan123 commented 1 year ago

If the example app starts all is good https://github.com/ShaMan123/react-native-math-view#running-example-app But it has been a long time since I touched it so it needs a bump in RN Are you up for that?

Do you have any docs pointing to this change?

Sorry for being a nag, I lost track and interest of RN ecosystem so it is a shot in the dark all this. I do remember RN was (still is?) a nightmare in terms of config and upgrade and extremely fragile so I want to exercise a bit of caution.

Since it is as you say it seems safe. Though I don't remember why I wanted to use it and commented those lines.

ShaMan123 commented 1 year ago

I see here it was removed https://github.com/react-native-community/cli/blob/8.x/docs/dependencies.md

Unfortunately there is not maintained CHANGELOG

Found it https://github.com/react-native-community/cli/releases/tag/v8.0.0-alpha.0