ShaastraWebops / ERP14

The Enterprise Resource Planner for Shaastra 2014
0 stars 0 forks source link

Dajax is still not working #4

Closed pandaops closed 11 years ago

pandaops commented 11 years ago

Clicking on Profile/contact still doesn't work on Chrome. There is a JS redirect bug also on Firefox.

AbdealiLoKo commented 11 years ago

First part Solved in c134b30

Another feature in this commit+fix is that dajax and dajaxice is now a module in "misc". This is a good approach that helps a lot. It makes the code larger, but it allows modularity between various years and other modules. So, right now, the only "dependency" the site has is django and python ... very minimal.

The firefox problem is still being worked on.

AbdealiLoKo commented 11 years ago

Commit ERP14@noreply.github.com fixes this issue completely.

As firefox doesn't associate the "click" event with "href", sometimes the js doesnt load properly/correctly.

Fix 1 : return false with the "href:javascript ..." eg : href="javascript:alert('a'); return false;") Fix 2 : use onclick ... put href="#" conclick="javascript:..." This allows all css effects to occur fine, as href is required for some effects + javascript runs with a javascript event (which is much more "natural" if you think about it.

So, I chose to use Fix2. And now it works fine. BUT : still not sure why this issue came up. Weirdly, this problem only came on the server, not locally ...