search

ShabbyX / RTAI

(NO LONGER MAINTAINED) Clone of RTAI from https://www.rtai.org
28 stars 17 forks source link

rtai-config stub script: add `-o` arg to select the 'only' headers found #22

Closed zultron closed 10 years ago

zultron commented 10 years ago

(Fixup for ShabbyX/RTAI#16)

If only one set of headers is found on the system, the -o option selects this kernel to build against. If more than one is found, error out.

The use case for this is on a build system where the running kernel is not an RTAI kernel, where exactly one set of RTAI kernel headers should be installed, and where it would be an irritating exercise to ask the build scripts to repeat many of the checks found in this script. ;)

zultron commented 10 years ago

Sorry, I thought this was going to be the default behavior for the stub script; another unambiguous case.

ShabbyX commented 10 years ago

Excellent! I was thinking about this case, but didn't think it would actually be used!

By the way, I'm going to give you write access to my repo, so you could comfortably push.

zultron commented 10 years ago

Thanks for push access! I'll likely continue using the PR workflow for non-trivial patches; it's probably wise to have another set of eyeballs watching in case I do something crazy. ;)

ShabbyX commented 10 years ago

@zultron, don't worry about another set of eyeballs, I do review commits made by others (which was previously only Alec), which is both for myself knowing what's going on as well as double checking the changes.

The weird thing with PRs here is that even if it's fast forward, I have to make another commit for the merge. Effectively every commit of yours becomes two commits with similar messages. If you don't feel like committing directly to master, you can always work on the dev branch, and let me know when it makes sense to merge, so I review the changes and do that.