search

ShacharHarshuv / open-ear

106 stars 20 forks source link

TriadInversion: enable a reversed arpeggiation direction #18 #185

Closed lungger closed 2 years ago

lungger commented 2 years ago

Shallow Copy and Deep Copy, these twos things have been bothering me, maybe you have more elegant method?

ShacharHarshuv commented 2 years ago

Hey, this PR contains 3 commits, but it should probably only contain the last one. You should either rebase from ShacharHarshuv:master, or create a new branch from ShacharHarshuv:master and cherry pick this last commit. Generally it's a good practice to make PRs from branches other then master, which should always be updated from the original master (aka ShacharHarshuv:master)

ShacharHarshuv commented 2 years ago

@lungger Hey, did you close this on purpose? Are you going to open a new one instead? It's good feature and I think we should add it 🙏

lungger commented 2 years ago

yes, i am going to open a new one