search

ShacharHarshuv / open-ear

106 stars 20 forks source link

Support more "chord types" #87

Closed ShacharHarshuv closed 2 years ago

ShacharHarshuv commented 2 years ago

Currently chord types supports major in minor, but note those are only the diatonic triads, so it actually only supports I ii iii IV V vi We need to enable more chord types, for every degree. So the user can, for example, enable a dominant 7th chord only for the V chord.

The options will be displayed on a grid where the columns are possible scale degrees (12 options) while the rows are chord types. It should also be possible to select / deselect an entire row in one click.

Common types to support: major, minor, diminished, dominant 7th, major 7th, minor 7th, sus4, sus2, major 6, diminished 7th, half diminished 7th,

Less common types to support: augmented, minor 6, minor major 7th, augmented dominant 7th, augmented dominant 7th, 9th, and all types of 9th, 11th, and 13th chords

ShacharHarshuv commented 2 years ago

Blocked by this: https://github.com/ShacharHarshuv/open-ear/pull/117 Currently we are constrained to using BaseCommonSettingsExercise, which we first need to illiminate.