search

Shad02w / Youtube-Chat-in-Fullscreen

Show Youtube live chat when in fullscreen mode
https://chrome.google.com/webstore/detail/youtube-chat-in-fullscree/kmhclnjhlejdjlkgeebolkigafpaijkp
GNU General Public License v3.0
39 stars 4 forks source link

Some chats do not render the chat window at all due to `message.runs` being undefined #19

Closed ek68794998 closed 3 years ago

ek68794998 commented 3 years ago

In some chats, the overlay does not appear at all. The following shows up in the console:

image

Which points to this, when formatted:

image

The runs property simply does not exist on this message.

image

To be honest, I've no idea what kind of message actually causes this. But it looks like some kind of simpleText field is getting pushed as a message. From the above, I looked for "Pokioo" on the page and found that it looks like the super chats have that text in them:

image

Not sure if this is an update to YouTube that caused this to break, or what, but it seems to completely cripple the overlay.

miraidave commented 3 years ago

I believe it's due to the new youtube function, "Free Member Milestone Chat". It looks like a green superchat but the it shows the membership duration instead of dollar amount. This difference is probably what's causing the issue.

Shad02w commented 3 years ago

@miraidave Is there any way i can find a stream with "Free Member Milestone Chat" ? so far I watch a few streams and havent found one.

Shad02w commented 3 years ago

@ekumlin It will be better if you can send me the link of the stream and time for me to test it

miraidave commented 3 years ago

Here's a link with Free Member Milestone Chats: https://www.youtube.com/watch?v=W7gUkrx2KPk

ek68794998 commented 3 years ago

Another option is this video at around 0:52.

Shad02w commented 3 years ago

v2.0.3 has been published, this bug should be fixed in ab4c9cad7a1b525a7c931db72ccf39c8bca2d11. If there is no futher problems, I am goning to close this issue

ek68794998 commented 3 years ago

Looks fixed to me.