Shade- / MyFacebook-Connect

A plugin to integrate Facebook with MyBB, letting users login and register through Facebook.
27 stars 24 forks source link

2.0 Issues #18

Closed amplifier1 closed 10 years ago

amplifier1 commented 10 years ago

I was testing the 2.0 version, not sure if you are aware of these issues or not.

Publishing feature is working.

Errors

<script>inc/db_mysqli.php</script>
<line>891</line>
<type>2</type>
<friendly_type>Warning</friendly_type>
<message>mysqli_free_result() expects parameter 1 to be mysqli_result, boolean given</message>

This error with Inlinesuccess message deactivated

<script>inc/functions.php</script>
<line>855</line>
<type>2</type>
<friendly_type>Warning</friendly_type>
<message>Cannot modify header information - headers already sent by (output started at /home/xxxx/public_html/xxxx/inc/class_error.php:215)</message>

This error with Inlinesuccess message activated

<script>inc/plugins/inlinesuccess.php</script>
<line>187</line>
<type>2</type>
<friendly_type>Warning</friendly_type>
<message>Cannot modify header information - headers already sent by (output started at /home/xxxxx/public_html/xxxxx/inc/class_error.php:215)</message>
Shade- commented 10 years ago

Thank you for your feedback. I will investigate through all of them, although they all seem to be warnings, not errors, thus they are not affecting the user experience.

Shade- commented 10 years ago

Very strange though. I cannot reproduce these warnings. Could you provide me the exact situations in which these three warnings are triggered? Thank you.

Shade- commented 10 years ago

Whatever. Fixed those headers already sent warnings by putting an ob_start() at the very top of the script. As for the first one, can you give me the trace of the error? I have placed many $db->free_result($query); in this release to speed up things, but I don't know which one is causing that warning.

Shade- commented 10 years ago

Never mind. Fixed that too.

amplifier1 commented 10 years ago

Thanks for all your hard work now it is working perfectly without any warnings or so :D