search

Shadnix-was-taken / BeatSaber-SaberTailor

A Beat Saber mod to customize the grip position/angle of the sabers, trail appearance and saber length/width.
MIT License
35 stars 8 forks source link

Saber Scaling: Width scaling may be applied multiple times for multiplayer mode #23

Closed Shadnix-was-taken closed 4 years ago

Shadnix-was-taken commented 4 years ago

Under certain conditions, saber scaling could be applied to sabers in multiplayer mode multiple times, resulting in thicker/thinner sabers then intended by the user.

Steps to reproduce:

  1. Start Beat Saber
  2. Enable scaling tweak and set saber width scaling to something different then 100%
  3. Play a map in multiplayer
  4. Play a map in solo mode
  5. Play another map in multiplayer - Sabers scaling is applied twice
Shadnix-was-taken commented 4 years ago

Based on early troubleshooting, once the game objects for multiplayer sabers get created, they stay around during solo mode (while solo mode sabers only exists during solo mode). It seems that scaling applied on sabers in a solo session then also get unintentionally applied to the lingering multiplayer saber objects.

Shadnix-was-taken commented 4 years ago

Fixed in v3.0.2