search

Shadnix-was-taken / BeatSaber-SaberTailor

A Beat Saber mod to customize the grip position/angle of the sabers, trail appearance and saber length/width.
MIT License
35 stars 8 forks source link

Add controller offset adjustments #25

Closed incertia closed 3 years ago

incertia commented 3 years ago

Applies the normal SaberTailor adjustments and then moves everything according to the controller offset, in case your controllers are not being reported in the correct location in your default standing location.

Currently the patch set is for version 2.9.0. I'll update this later to target 3.0.3 if there are any additional changes that need to be made.

Menus could use some adjustments, I let it scroll because I was lazy.

There is no need to change the config version, the config loader will automatically detect that there is no offset and apply a default of 0.

incertia commented 3 years ago

Updated for 3.0.3

incertia commented 3 years ago

@Shadnix-was-taken bump

Shadnix-was-taken commented 3 years ago

Hi. Sorry for not responding anytime sooner - I got drowned in work at my job and probably won't have much time to look over this for another couple of days. That hopefully settles down a bit after Christmas.

There is also the issue that this can (based on the description at least) be used to extend the offsets over the current limit, which is potentially a whole can of worms I'm not sure I want to touch... I have to think about this a bit more.

Again, sorry this took so long for a reply and still will take a bit of time.

incertia commented 3 years ago

if limits are a thing for scoresaber submission i can write some code to do something about it, but then again people can just compile their own version without the limits

incertia commented 3 years ago

i spoke with uninstaller late january and he was fine with the idea so i basically just kept the limits the same as what is used for normal offset

Shadnix-was-taken commented 3 years ago

Again, sorry for the late reply. I'm (again) buried in work at the moment.

Thanks for pointing to that conversation. Sounds like this should be good to go then. I'll try to review the PR in the next couple of days.