search

Shadnix-was-taken / BeatSaber-SaberTailor

A Beat Saber mod to customize the grip position/angle of the sabers, trail appearance and saber length/width.
MIT License
35 stars 8 forks source link

It doesn't load custom profile list correctly #27

Open nanikit opened 2 years ago

nanikit commented 2 years ago

Steps to reproduce

  1. Install SaberTailer v3.4.1 on beat saber 1.18.3 (I know I should test against the latest version, but I haven't migrated to the latest beat saber yet. If it was fixed, feel free to close.)
  2. Save any custom profile as different name in SaberTailor settings page.
  3. Apply the setting(restart beat saber).
  4. Open custom profile setting page again and tap custom profile name.

Expected behavior

It should show two profiles.

Actual behavior

It shows only one profile. I could correct it by saving another custom profile.

Just thought

It may need to improve UI.

Shadnix-was-taken commented 2 years ago

Hi there and thanks for reporting an issue. This sounds like a new issue that wasn't touched in the 3.5.0 release. If you can, please also test with the latest release. It should work on Beat Saber 1.18.3.

I'll try to take a look at the problem within the next couple of days.

One question, in order to avoid a possible confusion: When you save your first ever profile, the list should only show one entry, since it is the first time time you actually added one. The list up until that point should be "NONE AVAILABLE". After that, you should have one entry. Then additional entries for every new profile you save. Was this maybe the behaviour you observed? Or is the profile list also faulty for every additional saved profile?

Regarding the "load on select", I think I'd prefer to keep this as a two step process. Keep in mind that loading a profile will override the current active settings.

For the settings, I'd agree, although that part would need a cancel action in that case, I think. In general, I'd agree that the SaberTailor UI needs a major overhaul at this point. This is on my ToDo list, but currently held back due to a lack of enough spare time on my part.

nanikit commented 2 years ago

I have seen there was 'Default' profile after installing SaberTailor. I can't sure it was transfered from previous setting. I couldn't reproduce it not always. But I can't feel reliability on using profile feature. If no issue is found, close this. If I find more reliable reproducible steps then I will reopen this.