search

Shadnix-was-taken / BeatSaber-SaberTailor

A Beat Saber mod to customize the grip position/angle of the sabers, trail appearance and saber length/width.
MIT License
35 stars 8 forks source link

build: migrate project to sdk style #30

Closed nanikit closed 2 years ago

nanikit commented 2 years ago

It adopts BeatSaberModdingTools. Contributors will be able to setup beat saber path more easily in structured way.

I checked settings view is showing in BS1.19.0, but not extensively.

Just close this if there are any concerns.

Shadnix-was-taken commented 2 years ago

Hi there. Thank you for your pull request, and I'm very sorry that it took so long for me to reply.

I'll have to decline this one. Please note that is not because of any technical issues of your PR. There is a bit of backstory this topic:

I actually started a SDK conversion myself last year and then scrapped it again. This is because I had a little run-in on a different BS modding project, where I did expand the copyright notice in an attempt to credit other peoples work on the code. That prompted a bit of a discussion about the used license (MIT, same as used for this project). The discussion never came to a conclusion about how to expand the notice in a way that would satifsy all involved parties. So in the end, I just gave up on that part and want to stay clear of that topic in the future. It was not a fun experience to deal with and I don't want to use my little spare time for a discussion like that ever again, if I can avoid it.

Why is this relevant for this SDK-conversion? The conversion removes the AssemblyInfo.cs file, which contains a copyright notice, and fills the data in based on information in the manifest. Thus, that would change the copyright notice on the file. I haven't seen a simple way to keep those seperate, so that is where the conversion attempt ended. I didn't spend much time on it, so if there is way and someone let me know, I'll reconsider this. Until then, the current setup works 'good enough'.

Again, thank you very much for your time to submit this PR and I'm very sorry for not taking it in its current form.

nanikit commented 2 years ago

The conversion removes the AssemblyInfo.cs file, which contains a copyright notice, and fills the data in based on information in the manifest. Thus, that would change the copyright notice on the file.

Yes, it changes the copyright notice in the result assembly. It is derived from here.

I can change that string to the original Copyright © Steffan Donal 2018.

I haven't seen a simple way to keep those seperate.

But I can't fully figure out this. Apart from the string that embedded in the result assembly, what other string is necessary? Can it be solved by making copyright text file in the project?