search

ShadowApex / steamos-ubuntu

Scripts to make an existing Ubuntu installation like SteamOS
MIT License
110 stars 25 forks source link

Added if/else statements to ask for default user. #2

Closed CaptSilver closed 5 years ago

CaptSilver commented 5 years ago

Not a big deal. I know I could have overrode the environment vars, but I felt better if I added it to the script.

ShadowApex commented 5 years ago

@CaptSilver These are some great additions, thanks for the pull request!

In the future, try opening a pull request for each feature you want to add or change, instead of one large pull request with different changes. That way we can merge in each feature independently.

The only thing preventing me from accepting this PR is that it should be possible to run the script in a non-interactive way. Right now, with adding the graphics drivers PPA, it will prompt the user, even if NON_INTERACTIVE is set to true. We could actually probably auto-discover the graphics card by doing something like this:

if lspci | grep -i vga | grep -iq nvidia; then
    ...
elif lspci | grep -i vga | grep -iq amd; then
    ...
fi