ShadowBlip / PowerStation

Open source TDP control and performance daemon with DBus interface
GNU General Public License v3.0
27 stars 3 forks source link

Use asusctl to change TDP of supported devices #7

Closed Radiicall closed 2 months ago

Radiicall commented 7 months ago

Enables the use of asusctl to change TDP on supported devices (e.g. the ROG Ally)

pastaq commented 6 months ago

What all needs doing for this PR to move to ready?

Radiicall commented 6 months ago

What all needs doing for this PR to move to ready?

I'm having issues setting TDP on latest unstable release of chimera and havent had time to look into why, i thought it may have been related to ryzenadj but even after reverting the thermal throttle changes it didnt change anything

Radiicall commented 3 months ago

Is this functionality something still being considered? I know i havent looked at this in a while but i could probably get around to it

pastaq commented 3 months ago

Yeah, I meant to ask about it. Some of the endpoints will actually be exposed in sysfs soon, so that might be a better course. Also, we should add the platform_profile from ACPI and include safety checks to ensure if TDP is adjusted above/below certain thresholds that the platform_profile is automatically set.

pastaq commented 2 months ago

As we can use the interfaces provided by asusctl directly and it reduces the software requirements, #12 is a better overall solution. It also solves the fallback issue by making the AMDGPU TDPDevice interface separate from RyzenAdj and Asus WMI interfaces.