search

ShadowCraft / ShadowCraft-Engine

Calculations backend for ShadowCraft, a WoW theorycraft project.
GNU Lesser General Public License v3.0
15 stars 6 forks source link

Tier Bonus Ranking #3

Open Fierydemise opened 8 years ago

Fierydemise commented 8 years ago

In get_other_ep() 4pc bonuses should be compared without other tier 2pc and 4pc bonuses. Similarly 4pc bonuses should be evaluated only with that tier 2pc bonus. Whether to handle 2pc bonuses as 2pc/2pc or just one 2pc bonus should be handled as a flag.

confusingbits commented 8 years ago

I could work on this next. The problem is that the comparison is done with the currently equipped bonuses?

1) We wanted to just remove the bonuses for the baseline, and then apply them for the delta?

2 ) And ensure that only matching sets are calculated together for 4p?

3) And offer a flag to calc the 2/4p effect in a set independently?