search

ShadowMario / FNF-PsychEngine

Engine originally used on Mind Games mod
Apache License 2.0
1.06k stars 2.11k forks source link

Accuracy Weirdness #2327

Closed Templarfreak closed 2 years ago

Templarfreak commented 2 years ago

What feature do you want to get added on the base engine?

Right now, it seems like if you get the same score, but a better accuracy, your personal best accuracy displayed in the Freeplay menu does not change to reflect the new personal best. This can happen when you get an FC, but don't get perfect accuracy. FCing at any point, regardless of your actual accuracy, appears to always give you the same final score. This means that it won't update the accuracy pb with a new accuracy if you did better than your current pb on accuracy.

I suggest 1 of 2 things, either/or is fine, but both would be cool too:

  1. if your score is equal to your current pb but your accuracy is better, then set the currently saved pb to the new score+accuracy.
  2. make accuracy affect your score. IE if you get a shit or a bad it should be worth say, 50% of the points you would get normally, a good would be worth maybe 70%, and a sick is worth 100% of the points. (at least, it doesnt look like it already does something like this, from in-game and from glancing over the code). or you could make it really wild and scale it by how far away from a perfect hit you were, like a difference of say 1 millisecond would be 100 points * (1 - (ms_diff / 1000)), rounding however seems most appropriate, probably always rounding down

the second one is possibly too drastic of a change, but i think the first one should be an easy and reasonable one to make.

MeguminBOT commented 2 years ago

In my honest opinion number 2 isn't too drastic, this is how literally almost every rhythm game does it anyways :P Like osu!mania uses 320 points for a sick hit within a 17ms window if I'm not wrong and then 300 for any other sick hits. Then 200 for Good and 100 for bad.

ShadowMario commented 2 years ago

The accuracy saved is the accuracy from your best score, not your best accuracy.

Templarfreak commented 2 years ago

Yes. That's exactly. The reason. Why I opened. This issue. That should change. If you achieve the same score but a better accuracy, it should save the "new score" so that the pb reflects your new best accuracy.

There is an effective maximum score achievable on a chart, by getting an FC. But you can NOT get 100% accuracy, and still get an FC and the maximum possible score for that chart. Meaning, you can do BETTER than your current PB and the game will not update to reflect this.