ShadowMario / FNF-PsychEngine

Engine originally used on Mind Games mod
Apache License 2.0
1.11k stars 2.17k forks source link

Vocals/Inst being not equal in length causes the shorter audio to loop to accomodate for the longer audio #9515

Closed RowanSkie closed 2 years ago

RowanSkie commented 2 years ago

Describe your bug here.

A more bearable version of https://github.com/ShadowMario/FNF-PsychEngine/issues/8400, which has been marked as closed. For those that want to know and duplicate, here is how.

  1. Your audio files, Inst.ogg and Vocals.ogg don't have the exact same length. In vanilla/base gameplay, that's Week 6's Thorns.
  2. Play normally until the end.

For Thorns, it should be a few seconds of pure silence as Inst.ogg is longer than Vocals.ogg, but the latest updates have caused Vocals.ogg to basically restart just as Inst.ogg ends.

8400 is what happens on pre-Week 7 game engines, including Kade Engine, pre-0.6 Psych Engine, and the downloadable Itch.io build.

Virtually every build has this problem unless they're playing the Newgrounds/Week 7 version if I recall correctly.

At least Psych's audio bug sounds better instead of "screeching noises".

Command Prompt/Terminal logs (if existing)

No response

Are you modding a build from source or with Lua?

Source

What is your build target?

Windows

Did you edit anything in this build? If so, mention or summarize your changes.

No edits, it's an ontouched build.

RowanSkie commented 2 years ago

Closing this, bug is actually really fixed.