ShadowOne333 / MaternalBound-Redux

A new version of MaternalBound, complete with New Controls and MSU-1 integration... And a lot more features!
GNU General Public License v3.0
87 stars 7 forks source link

MBRedux patch seems to break Piggy Nose item + minor spelling error #2

Open vic-viper-001 opened 3 years ago

vic-viper-001 commented 3 years ago

The "Piggy Nose" item (purchased in Scaraba and used to find magic Truffles in Deep Darkness) seems broken. You will keep getting the 'no magic truffles nearby' message even if you use the Piggy nose while standing right next to one. Regardless, you can still collect the Magic Truffles if you already know where there are on the map.

A minor spelling error also exists at the Montoly Building in Fourside. A security guard says someone might "take a shoot at you", instead of "take a shot".

ShadowOne333 commented 3 years ago

This is caused because I obliviously repurposed a sprite that was previously a "blank" sprite inside SpriteGroups for a custom enemy sprite, not knowing that this was used for the Magic Truffles in-game. A simple way to fix it would be to change entries 1240-1244 inside npc_config_table.yml to use sprite #440 instead of 381.

As for the text, that should be a matter of doing a simple search and replace "shoot" with "shot".

MAGNAT2645 commented 3 years ago

I use SpriteGroups from your hack and tried to change Sprite to 440, the Piggy Nose still doesn't work.

MAGNAT2645 commented 3 years ago

So i fixed this. [1F D1] control code calls a subroutine at $C490EE. This subroutine then loads SpriteGroups index into accumulator, then calls unknown subroutine at $C46028 (i assume this has something to do with TPT entry).

So i just replaced that index to #$01B8 (440). ROM[0xC490F6] = LDA_i(0x01B8)

ShadowOne333 commented 1 year ago

I think I tackled this issue but just forgot about it, can someone please test if the latest version of the patch fixes this issue? I seem to remember implementing the fix and uploading it, but I forgot to say anything about it