search

ShadowOne333 / The-Legend-of-Zelda-Redux

Source code for the hack The Legend of Zelda Redux
GNU General Public License v3.0
99 stars 9 forks source link

Update automap.asm #2

Closed cyneprepou4uk closed 3 years ago

cyneprepou4uk commented 3 years ago

optimization

ShadowOne333 commented 3 years ago

Thanks for the pull request, cyneprepou4uk! I checked the code on my end by making the appropriate changes.

However, I noticed that the AND/BEQ implementation makes the cursor blink at random times and in a very rapid and short manner compared to the original LSR/BCC code.

You can check it out on your end, with the LSR method, the cursor blinks in a very well timed sequence, but with the AND method, the cursor remains present for like 1-2 seconds, and then blinks very rapidly, exactly one frame, and goes back to being static for 1-2 seconds.

Let me know if it happens on your end as well.

cyneprepou4uk commented 3 years ago

I see what you mean. I misunderstood the code. Nevermind that pull request then.