search

ShadowOne333 / The-Legend-of-Zelda-Redux

Source code for the hack The Legend of Zelda Redux
GNU General Public License v3.0
110 stars 11 forks source link

Game Crashes on Dungeon 4 1st Quest with Original HUD #23

Open RodimusPrimal opened 2 months ago

RodimusPrimal commented 2 months ago

With the original HUD, the game will crash on the first quest when trying to enter the second room in Dungeon 4.

ShadowOne333 commented 2 months ago

Oh my thank you SO much for this report. I've been getting reports about a crash when entering Dungeon 4 for years, and I wasn't able to reproduce it because (from what I recall) no one mentioned before that they were using the Original HUD as optional patch.

That's the culprit of the issue, now I can reproduce it every time. Not only that, but the game also crashes on Dungeon 5 for 2nd Quest with this patch as I found out by mistake.

I'll check what the issue could be with the Original HUD code, shouldn't take long now that I have reproduced it consistently.

ShadowOne333 commented 2 months ago

Update: After some testing, it seems like the Original HUD optional patch is working just fine, so that one is not the issue itself. The problem however comes from the Dungeon Automap hack, which is implemented into the main Redux patch. Seems like the Dungeon Automap combined with the Original HUD optional patch is what's triggering the crash.

That one seems to be the one causing the crash when changing rooms in both Dungeon 4 of 1st Quest and also Dungeon 5 of 2nd Quest. I still haven't figured out exactly what part of that code is causing the crash, but if I comment that specific code out, the Original HUD optional patch works out just fine.

So guess this will require some heavy debugging, since this code was made by an user that's long gone from the scene.

RodimusPrimal commented 2 months ago

Someone on RHDN seemed to find the root cause of the error. The bomb graphic is in the name table.

RodimusPrimal commented 2 months ago

Copying my response on RHDN in case you don't see it there - Just tested it after changing the Hex value and it seems to fix it. At least for Level 4 on the 1st Quest.