Closed jcotton42 closed 2 years ago
Don't merge this just yet, there's some additional tweaks I want to make to the Dockerfile, like setting NODE_ENV in the appropriate stages instead of relying on them being set in the Compose file.
NODE_ENV
It's all ready to go!
Things left to do:
npm run prod
node
init
Don't merge this just yet, there's some additional tweaks I want to make to the Dockerfile, like settingNODE_ENV
in the appropriate stages instead of relying on them being set in the Compose file.It's all ready to go!
Things left to do:
NODE_ENV
in Dockerfilenpm run prod
properly handles signals. It doesn't seem to https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#cmd andnode
itself may need a wrapperinit
process https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#handling-kernel-signals. It appears that the latter can be set in the compose and swarm definitions https://docs.docker.com/compose/compose-file/#init.