search

Shadowfiend / sbt-resource-management

Provides tasks to compile coffee script and compass/SASS files, plus tasks to bundle and upload to S3.
http://hacklanta.com/
MIT License
21 stars 7 forks source link

YUI Compressor needed in classpath. #13

Closed farmdawgnation closed 10 years ago

farmdawgnation commented 11 years ago

I'm blowing you up today as I'm trying to get this Anchor Tab production server running. :P

Looks like YUI isn't in the classpath, and thus compressing anything won't work, unless you manually add it using project/build.sbt. My suspicion is that this could be fixed by making it a libraryDependency in sbt-resource-management's build.sbt file.

I don't want to write, submit, and test a patch right now (I am still trying to get this server up), but if you agree I can do so at some point in the near future.

Shadowfiend commented 11 years ago

But... We're already doing compression, both CSS and js, on OpenStudy, no?

farmdawgnation commented 11 years ago

It would seem that for OpenStudy we manually placed yui inside project/lib instead of listing it as a dependency somewhere for SBT to fetch for us. Hence, why OpenStudy builds just fine, and Anchor Tab does not.

matt@FarmStudy:~/Sites/openstudy-v2/project/lib(master)$ ls -a
.           ..          yuicompressor-2.4.4.jar
Shadowfiend commented 11 years ago

Aha. This is because recent maven versions of yui are busted in a variety of ways and the latest yui is not actually in the maven repos (or wasn't) I think...

farmdawgnation commented 11 years ago

Got it. So, 2.4.7 appears to be in maven. We're using 2.4.4 in the OS codebase. So, perhaps they got the issue resolved?

Shadowfiend commented 11 years ago

Maybe. If you want to give it a test run with the openstudy repo, I'd be happy to drop the dependency in this suckah, then.

Shadowfiend commented 11 years ago

Any news on this?

farmdawgnation commented 11 years ago

I've been successfully using 2.4.7 with Anchor Tab in production for awhile now. Just added it as a libraryDependency in my plugins.sbt file. Adding it as a dependency in sbt-resource-management should be safe and prevent the need for someone to manually add that to their plugins.sbt.

Shadowfiend commented 11 years ago

Any chance you could add that dependency and attach a pull request to this issue for it?

farmdawgnation commented 11 years ago

Oy. Sorry, just now getting around to responding to this. Certainly can. I'll add it to my list-o-stuff to do.

farmdawgnation commented 10 years ago

Lol. Whoops.

farmdawgnation commented 10 years ago

Boom.

th0br0 commented 10 years ago

Bang. On 19 Oct 2013 22:09, "Matt Farmer" notifications@github.com wrote:

Boom.

— Reply to this email directly or view it on GitHubhttps://github.com/Shadowfiend/sbt-resource-management/pull/13#issuecomment-26657836 .

Shadowfiend commented 10 years ago

Ratatat, boom! Sorry, I'll try and get this in later today or tomorrow.

Shadowfiend commented 10 years ago

Solid.

Shadowfiend commented 10 years ago

This is currently deployed in 0.4.1-SNAPSHOT.