search

Shadows-of-Fire / Apotheosis

All things that should have been.
Other
155 stars 120 forks source link

Add support for custom potion charms made with commands or KubeJS #1149

Closed eehunter closed 2 months ago

eehunter commented 5 months ago

This changes the internal logic of the PotionCharmItem class so that it will function as intended if it is created with a custom effect instead of a registered potion type. This does not provide any way to obtain such a Potion Charm that was not already available. This is intended primarily for use by modpack developers.

eehunter commented 5 months ago

This is marked as a draft for now, as I am not able to test the code at this time.

eehunter commented 4 months ago

I've tested it and fixed one issue, seems to work.

Shadows-of-Fire commented 2 months ago

Added manually in https://github.com/Shadows-of-Fire/Apotheosis/commit/2f5e83ee38ef135a78322f40ce535d4b8b18f77b