search

Shadows-of-Fire / Apotheosis

All things that should have been.
Other
155 stars 120 forks source link

1.19.2 Backport #1161

Closed SiverDX closed 3 months ago

SiverDX commented 4 months ago

Requires: https://github.com/Shadows-of-Fire/Placebo/pull/78

Commits

SiverDX commented 4 months ago

I believe there are also some other missing changes, like the number adjustments in the rogue spawner features. Not sure if anything else is obviously absent.

you meant this, right? https://github.com/Shadows-of-Fire/Apotheosis/pull/1161/commits/95820d476baf94ea18be71d5569242db11a9661b

increased the max. value and added a separate config for the deep ones in https://github.com/Shadows-of-Fire/Apotheosis/pull/1161/commits/3cfb8bb738226e9900307912c27a31f2de928fd3

SiverDX commented 4 months ago

Should the AllStat change be done as a new affix type so existing datapacks don't break?

Shadows-of-Fire commented 4 months ago

No, but you'll have to hook up a codec that is capable of parsing the old form and producing the new list (all vanilla/forge/apoth attributes).

This should be doable with an optional field that has a fallback to the default list.

SiverDX commented 3 months ago

https://github.com/Shadows-of-Fire/Apotheosis/pull/1161/commits/5ec51a86e1214b1707848696fa35b9c0e80b124f

singleplayer the block list was empty (i.e. it triggers for all blocks) and on a server it didn't seem to drop anything for tag additions (i can't exclude the chance of just getting super unlucky but it did keep working for the default tag entries)

Shadows-of-Fire commented 3 months ago

On the client thread the list can be empty as it will never be used (modifyLoot can never be called on the client thread)

But yeah there isn't much reason to resolve the blocks when is(TagKey) exists

SiverDX commented 3 months ago

i meant its empty in singleplayer, not client singleplayer also runs a server thread and it was empty there

Shadows-of-Fire commented 3 months ago

Proper fix is e9efd6b1758439322f6218fb8850bc3a3606bb02 Your solution doesn't preserve the "run on all blocks" behavior (without making a tag containing everything, which is nontrivial).

SiverDX commented 3 months ago

ok didn't know it did that - missed the comment