search

Shadows-of-Fire / Apotheosis

All things that should have been.
Other
151 stars 119 forks source link

1.19.2 bug #1226

Closed AinSpoh closed 2 months ago

AinSpoh commented 2 months ago

Minecraft Version:1.19.2 Forge Version:43.3.0 Mods:Apotheosis6.5.0, Tetra:5.6.0, L2 Complements 1.4.10 (and front mods) Description of issue :when put apotheosis weapon in tetra workbench,FPS will drop sharply(almost crash) i asked l2's developer,they said the problem is 1.19.2 apotheosis.(in 1.20.1these mod are running normally) Hope you can fix this issue as soon as possible p1

p2

Shadows-of-Fire commented 2 months ago

You would need to provide a client render spark profile to triage what is happening. I suspect the issue does not lie with apotheosis.

AinSpoh commented 2 months ago

https://spark.lucko.me/eFXHVd2w1a

SiverDX commented 2 months ago

that's server you need to provide a client one using /sparkc

AinSpoh commented 2 months ago

sorry, this is my first time using Spark https://spark.lucko.me/uZAWpHBDBz

SiverDX commented 2 months ago

in case the report dies not sure who is at fault here

tetra is constantly checking if the item is broken which leads to this being called: https://github.com/Minecraft-LightLand/L2Complements/blob/9ecad71d6d93e5e2cf62ee98d6d418ccb58f4bb7/src/main/java/dev/xkmc/l2complements/mixin/ItemStackMixin.java#L51

which leads to the whole enchantment (and therefor gem) stuff being checked

which leads to tool actions being checked which are not very performant for tetra items

image

image

AinSpoh commented 2 months ago

Okay, thank you for answering my question