search

Shadows-of-Fire / Apotheosis

All things that should have been.
Other
151 stars 119 forks source link

[Bug] Incompatible with mod "Golden Age Combat" #1227

Closed Naireem-sudo closed 1 month ago

Naireem-sudo commented 2 months ago

Apotheosis overrides the enchantment "Sharpness" and Golden Age Combat too. It will ignore the "Boost Sharpness Enchant" from Golden Age Combat (from 0.5 dmg to 1.25 dmg increase).

Shadows-of-Fire commented 1 month ago

This is because Apoth is also rebalancing sharpness (and the other bane enchantments) to accommodate Apoth making Sharpness compatible with a single bane enchantment. These rebalancings can never implicitly be compatible with one another. Golden Age Combat should be able to apply whatever mixin they are applying to the vanilla enchantment class to mine to achieve a similar result.

https://github.com/Shadows-of-Fire/Apotheosis/blob/1.20/src/main/java/dev/shadowsoffire/apotheosis/ench/replacements/BaneEnchant.java