Unregistered features and structures

[cheshyrp]

According to Blame, a few features and structures were not configured, which can break other mods.

****************** Blame Report 1.16.5-3.2.3-forge ******************

 This is an experimental report. It is suppose to automatically read
 the JSON of all the unregistered ConfiguredFeatures, ConfiguredStructures,
 and ConfiguredCarvers. Then does its best to collect the terms that seem to
 state whose mod the unregistered stuff belongs to.

Possible mods responsible for unregistered stuff:

apotheosis:boss_dungeon
apotheosis:boss_dungeon_2
apotheosis:rogue_spawner
apotheosis:trove

****************** Blame Report 1.16.5-3.2.3-forge ******************

 This ConfiguredFeature was found to be not registered. Look at the JSON info and try to
 find which mod it belongs to. Then go tell that mod owner to register their ConfiguredFeature
 as otherwise, it will break other mods or datapacks that registered their stuff.

 JSON info : {
  "config": {
    "feature": {
      "config": {
        "feature": {
          "config": {
            "feature": {
              "config": {},
              "type": "apotheosis:trove"
            },
            "decorator": {
              "config": {
                "bottom_offset": 0,
                "top_offset": 0,
                "maximum": 64
              },
              "type": "minecraft:range"
            }
          },
          "type": "minecraft:decorated"
        },
        "decorator": {
          "config": {},
          "type": "minecraft:square"
        }
      },
      "type": "minecraft:decorated"
    },
    "decorator": {
      "config": {
        "count": 8
      },
      "type": "minecraft:count"
    }
  },
  "type": "minecraft:decorated"
}

 Biome affected : [byg:evergreen_hills, blue_skies:snow_covered_pines, twilightforest:enchanted_forest, atmospheric:rainforest_mountains, twilightforest:mushroom_forest, byg:great_lake_isles, minecraft:basalt_deltas,
                   atmospheric:sparse_rainforest_basin, minecraft:snowy_taiga_hills, byg:meadow, byg:ethereal_clearing, twilightforest:highlands, byg:seasonal_forest, terraforged:cold_steppe,
                   atmospheric:rainforest, betterendforge:lantern_woods, blue_skies:rising_creek, minecraft:giant_spruce_taiga, byg:bulbis_gardens, byg:tropical_islands, autumnity:yellow_spotted_forest,
                   byg:aspen_forest, byg:enchanted_forest_hills, byg:zelkova_forest_hills, minecraft:nether_wastes, byg:white_beach, betterendforge:foggy_mushroomland, byg:seasonal_birch_forest,
                   minecraft:snowy_taiga, byg:brimstone_caverns, terraforged:flower_plains, minecraft:stone_shore, byg:boreal_forest_hills, byg:amaranth_fields, byg:blue_giant_taiga,
                   byg:the_black_forest, minecraft:tall_birch_forest, environmental:blossom_woods, byg:magma_wastes, byg:maple_taiga, twilightforest:forest, minecraft:plains,
                   twilightforest:thornlands, byg:shulkren_forest, twilightforest:swamp, byg:red_oak_forest, byg:dummy, byg:seasonal_giant_taiga, byg:wooded_grassland_plateau,
                   minecraft:warped_forest, byg:ivis_fields, betterendforge:dust_wastelands, twilightforest:oak_savannah, twilightforest:dark_forest, byg:skyris_steeps, byg:seasonal_birch_forest_hills,
                   byg:snowy_evergreen_clearing, byg:snowy_black_beach, byg:snowy_blue_giant_taiga, byg:black_forest_clearing, minecraft:giant_tree_taiga_hills, byg:zelkova_forest, minecraft:taiga_hills,
                   byg:redwood_mountains, byg:deciduous_clearing, byg:bulbis_gardens_edge, environmental:blossom_hills, byg:sierra_range, betterendforge:umbrella_jungle, minecraft:giant_tree_taiga,
                   byg:weeping_witch_clearing, terraforged:snowy_taiga_scrub, blue_skies:brumble_forest, minecraft:crimson_forest, byg:bamboo_forest, byg:shattered_desert_isles, twilightforest:fire_swamp,
                   byg:prairie_clearing, byg:wooded_meadow, byg:skyris_peaks, betterendforge:empty_aurora_cave, twilightforest:dense_forest, minecraft:forest, betterendforge:shadow_forest,
                   minecraft:end_midlands, byg:forest_fault, minecraft:sunflower_plains, minecraft:gravelly_mountains, byg:withering_woods, byg:dover_mountains, byg:sierra_valley,
                   autumnity:pumpkin_fields, betterendforge:empty_end_cave, byg:ebony_hills, minecraft:beach, byg:seasonal_forest_hills, endergetic:poise_forest, byg:pointed_stone_forest,
                   betterendforge:amber_land, byg:red_rock_highlands, autumnity:maple_forest_hills, byg:seasonal_deciduous_forest, twilightforest:firefly_forest, autumnity:red_spotted_taiga, twilightforest:spooky_forest,
                   atmospheric:rainforest_plateau, byg:prairie, byg:skyris_highlands_clearing, betterendforge:empty_smaragdant_cave, byg:red_spruce_taiga, byg:ebony_woods, byg:crimson_gardens,
                   blue_skies:shaded_woodlands, blue_skies:polar_highland, byg:red_rock_lowlands, minecraft:giant_spruce_taiga_hills, atmospheric:rainforest_basin, byg:zelkova_clearing, minecraft:birch_forest,
                   minecraft:mountains, twilightforest:snowy_forest, minecraft:soul_sand_valley, byg:quartz_desert, blue_skies:frostbitten_forest_clearing, byg:orchard, byg:blue_taiga,
                   byg:basalt_barrera, byg:flowering_grove, byg:pumpkin_forest, byg:seasonal_deciduous_clearing, byg:coniferous_forest, blue_skies:brisk_meadow, byg:blue_taiga_hills,
                   byg:snowy_coniferous_clearing, betterendforge:lush_smaragdant_cave, betterendforge:sulphur_springs, blue_skies:crescent_orchard, byg:aspen_clearing, terraforged:taiga_scrub, byg:coniferous_forest_hills,
                   byg:twilight_valley_hills, minecraft:modified_gravelly_mountains, byg:cryptic_wastes, byg:red_oak_forest_hills, byg:ethereal_islands, byg:warped_desert, blue_skies:frostbitten_forest,
                   byg:rainbow_beach, byg:shattered_viscal_isles, blue_skies:searing_grassland, byg:twilight_valley, terraforged:frozen_lake, byg:grassland_plateau, minecraft:frozen_river,
                   byg:wooded_red_rock_mountains, byg:flowering_enchanted_grove, byg:deciduous_forest_hills, byg:cherry_blossom_clearing, byg:embur_bog, byg:dead_sea, byg:glowstone_gardens,
                   terraforged:savanna_scrub, byg:viscal_isles, byg:boreal_clearing, minecraft:mountain_edge, minecraft:river, byg:coniferous_clearing, byg:enchanted_forest,
                   minecraft:the_void, terraforged:warm_beach, byg:weeping_witch_forest, byg:nightshade_forest, minecraft:wooded_hills, byg:glowing_ancient_forest, byg:seasonal_taiga_hills,
                   terraforged:fir_forest, minecraft:end_highlands, byg:black_forest_hills, blue_skies:deep_peeking_ocean, terraforged:lake, byg:imparius_clearing, byg:cika_mountains,
                   byg:snowy_coniferous_forest, byg:araucaria_savanna, blue_skies:moonlit_reservoir, blue_skies:crystal_roughs, byg:rose_fields, byg:woodlands, byg:snowy_coniferous_forest_hills,
                   byg:bluff_peaks, minecraft:birch_forest_hills, byg:maple_hills, byg:red_rock_mountains, minecraft:snowy_beach, byg:aspen_forest_hills, byg:skyris_highlands,
                   autumnity:maple_forest, byg:great_lakes, byg:boreal_forest, byg:wailing_garth, byg:cika_woods, byg:shattered_desert, blue_skies:sunset_maple_forest,
                   twilightforest:clearing, blue_skies:calming_skies, byg:weeping_mire, byg:redwood_tropics, byg:seasonal_deciduous_forest_hills, byg:redwood_clearing, betterendforge:dry_shrubland,
                   outer_end:azure_forest, betterendforge:megalake, minecraft:tall_birch_hills, minecraft:snowy_taiga_mountains, betterendforge:megalake_grove, byg:enchanted_grove, byg:sythian_torrids,
                   minecraft:savanna_plateau, terraforged:shattered_savanna_scrub, blue_skies:crystal_dunes, minecraft:taiga, minecraft:wooded_mountains, minecraft:savanna, byg:purpur_peaks,
                   byg:allium_fields, byg:snowy_rocky_black_beach, environmental:blossom_valleys, byg:evergreen_taiga, byg:bluff_steeps, byg:ethereal_forest, byg:snowy_blue_taiga_hills,
                   byg:flowering_meadow, byg:alpine_foothills, blue_skies:midday_shore, byg:flowering_ancient_forest, betterendforge:neon_oasis, byg:snowy_blue_taiga, twilightforest:stream,
                   byg:imparius_grove, byg:ancient_forest, byg:grove, minecraft:flower_forest, desolation:charred_forest, betterendforge:lush_aurora_cave, minecraft:shattered_savanna_plateau,
                   twilightforest:lake, betterendforge:chorus_forest, byg:seasonal_taiga, byg:cherry_blossom_forest, minecraft:shattered_savanna, byg:autumnal_valley, byg:stone_forest,
                   atmospheric:sparse_rainforest_plateau, byg:snowy_evergreen_taiga, byg:baobab_savanna, terraforged:steppe, betterendforge:dragon_graveyards, environmental:blossom_highlands, byg:araucaria_forest,
                   twilightforest:glacier, minecraft:end_barrens, betterendforge:glowing_grasslands, blue_skies:peeking_ocean, minecraft:small_end_islands, byg:subzero_hypogeal, minecraft:the_end,
                   minecraft:taiga_mountains, byg:rocky_beach, twilightforest:final_plateau, byg:evergreen_clearing, outer_end:crystal_crag, blue_skies:crescent_orchard_lake, betterendforge:painted_mountains,
                   blue_skies:crystal_dunes_spikes, betterendforge:blossoming_spires, betterendforge:crystal_mountains, blue_skies:unorthodox_valley, twilightforest:dark_forest_center, byg:deciduous_forest, twilightforest:dense_mushroom_forest,
                   blue_skies:slushlands, druidcraft:darkwood_forest, byg:snowy_evergreen_hills, blue_skies:brightlands, betterendforge:ice_starfield]

[Shadows-of-Fire]

all configured features within apotheosis are registered, the code responsible is here https://github.com/Shadows-of-Fire/Apotheosis/blob/1.16/src/main/java/shadows/apotheosis/deadly/DeadlyWorldGen.java#L24

[cheshyrp]

There are literally dozens of error lines in the server log from Apotheosis alone, and all of them are due to unregistered features. I've been a software developer since 1981, so I understand what you're saying, but clearly something isn't working as intended. Shouldn't BOSS_DUNGEON, BOSS_DUNGEON_2 and TOME_TOWER be registered as structures? Perhaps this is why Blame reports it as an error? I've posted a report on Blame's issue page in case it's a false positive.

[TelepathicGrunt]

all configured features within apotheosis are registered, the code responsible is here https://github.com/Shadows-of-Fire/Apotheosis/blob/1.16/src/main/java/shadows/apotheosis/deadly/DeadlyWorldGen.java#L24

Actually, blame is right. If you breakpoint here: https://github.com/TelepathicGrunt/Apotheosis/blob/7c4b3788ab122aa06501de31535d6029aad8cee5/src/main/java/shadows/apotheosis/deadly/DeadlyWorldGen.java#L30

and look at what f.feature is, it is "minecraft:decorated". All of these ConfiguredFeatures were registered under that name which means all but one were registry replaced and now are unregistered. Which triggered the Blame report.

Remember, every placement you do on a configuredfeature, wraps that configuredfeature in a NEW one that runs the placement code. (only the outermost configuredfeature instance used for worldgen is the one that needs to be registered) For your Boss Dungeon, it actually waaaaay buried inside nested configuredfeatures like this:

My recommendation is to just register each configuredfeature field separately and with a resourcelocation you create yourself. Short, simple, and less likely to have an issue. Hope this helps!