search

Shadows-of-Fire / Apotheosis

All things that should have been.
Other
181 stars 132 forks source link

Config option to pick which potions get charms, and their "tier" to split up when they're available #592

Open Hexicube opened 2 years ago

Hexicube commented 2 years ago

Right now you can only mass-change all charms with the potion_charm_enchanting.json data file, it would be nice if instead every potion had a toggle to enable it and a tier choice that had its own infusion recipe.

This would allow, for instance: infusing some potions like haste and night vision pre-wither, stronger potions like resistance and fire resistance pre-end (if shelves are appropriately tweaked), and the strongest potions post-end like regeneration and absorption.

If it's not possible to dynamically generate tiers I'd imagine 6 is enough for any reasonable modded config: Overworld (via some modded way to get potions), Nether, Wither, Dragon, some further modded cutoff, and one to spare just in case.

Semi-related: Not sure if bookshelf data files let you set max stat values for quanta and arcana, if not that would be nice to have for side-gating (such as wither stars for maxing out arcana). It'd also be nice for the level cap of 50 to instead be worked out via the data files, if that's not already the case.

Shadows-of-Fire commented 2 years ago

Problem with doing this tends to come down to the JEI handling, splitting up the recipes into categories is not as simple as allowing more recipes to be added for subsets of the available charms.

I might look into it at some point, but it might take a while.

Though I wonder, why do you want a blacklist for certain potions?

Semi-related: Not sure if bookshelf data files let you set max stat values for quanta and arcana, if not that would be nice to have for side-gating (such as wither stars for maxing out arcana). It'd also be nice for the level cap of 50 to instead be worked out via the data files, if that's not already the case. That is all done in the jsons

Hexicube commented 2 years ago

Though I wonder, why do you want a blacklist for certain potions?

Some charms, such as wither, don't really make sense as something you'd want to have in most cases, so being able to remove it entirely to de-clutter JEI would be nice.

It isn't a huge deal. I was more concerned with being able to make some permanent charms early for convenience, since something like haste isn't going to help you progress easier.

Bookshelf stuff - That is all done in the jsons

Wasn't sure if this was the case. There was no existing example of a bookshelf that, for instance, boosted arcana but stops at 75%. I also wasn't sure if you could exceed 50 levels.

Shadows-of-Fire commented 3 months ago

The blacklist has been implemented in 7.4.1 - still nothing for the per-potion recipes though.