search

Shadows-of-Fire / Apotheosis

All things that should have been.
Other
179 stars 129 forks source link

[1.19.2] [6.3.0] Step height incompatible with stepup #956

Closed Xetaxheb closed 1 year ago

Xetaxheb commented 1 year ago

Whether the source is something like stepup or Artifacts running shoes (actually not this one, must have been some other incompatibility), other mods step height does not function while Apotheosis is installed.

Xetaxheb commented 1 year ago

Not totally sure if any of these are relevant but figured I'd put them here:

https://github.com/Shadows-of-Fire/Apotheosis/blob/c502c2a6c15d6a6ff9728acadccc85172f58cfe5/src/main/java/shadows/apotheosis/mixin/IForgeEntityMixin.java#L25

https://github.com/Shadows-of-Fire/Apotheosis/blob/c502c2a6c15d6a6ff9728acadccc85172f58cfe5/src/main/java/shadows/apotheosis/core/attributeslib/AttributesLib.java#L107

https://github.com/Shadows-of-Fire/Apotheosis/blob/c502c2a6c15d6a6ff9728acadccc85172f58cfe5/src/main/java/shadows/apotheosis/core/attributeslib/impl/AttributeEvents.java#L68

Xetaxheb commented 1 year ago

And the ways the two mentioned mods do it:

https://github.com/spoorn/StepItUp/blob/main/common/src/main/java/org/spoorn/stepitup/mixin/ClientPlayerEntityMixin.java#L32

https://github.com/ochotonida/artifacts/blob/1db8c1eae7bc546ce295232e37435df6ddae7deb/src/main/java/artifacts/item/wearable/feet/RunningShoesItem.java#L22 (not this, actually)