search

Shadows-of-Fire / Apothic-Attributes

Attributes library for Minecraft, used by Apotheosis.
MIT License
7 stars 9 forks source link

Made Attributes GUI button visible and functional in Curios GUI #15

Closed BookerCatch closed 3 months ago

BookerCatch commented 5 months ago

Currently, the Attributes GUI toggle button vanishes when the Curios GUI is opened. This pull request makes it so the Attributes GUI toggle button renders in the Curios GUI, and allows the player to swap from it to the Attributes GUI and vice versa.

SiverDX commented 5 months ago

did you test this without curios? or does the exception just get swallowed up by sth.

https://github.com/Shadows-of-Fire/Apothic-Attributes/blob/33a9f7c7f28aaa0562a97a7737cb561c846202b5/src/main/java/dev/shadowsoffire/attributeslib/AttributesLib.java#L67-L71

https://github.com/Shadows-of-Fire/Apothic-Attributes/blob/33a9f7c7f28aaa0562a97a7737cb561c846202b5/src/main/java/dev/shadowsoffire/attributeslib/client/CuriosClientCompat.java#L18-L22

in the current usage there is an additional check for curios

https://github.com/Shadows-of-Fire/Apothic-Attributes/blob/f2c025fe1ba5a97df72b6f2de005360b9e262eeb/src/main/java/dev/shadowsoffire/attributeslib/AttributesLib.java#L132-L134

BookerCatch commented 5 months ago

I thought I had tested without Curios, but you're right; now it depends on Curios. Will revise.

BookerCatch commented 5 months ago

Alright, it will now load and work with or without Curios.