Shadows-of-Fire / Apothic-Attributes

Attributes library for Minecraft, used by Apotheosis.
MIT License
14 stars 11 forks source link

Tooltips still render with quark's improved tooltips #29

Open Lucky-56 opened 6 months ago

Lucky-56 commented 6 months ago

Forge: 47.2.30

Mod version: ApothicAttributes-1.20.1-1.3.4

Other Mods:

tooltip

nothing much to tell, just to show.

Shadows-of-Fire commented 6 months ago

Apoth's modifications don't take well to being displayed with the compressed quark tooltips. Previously I was just disabling their tooltips on affixed items (and disabling mine on normal items), but I guess since their 1.20 refactor that code isn't functional anymore.

Lucky-56 commented 6 months ago

yikes so report to quark aswell then?

Shadows-of-Fire commented 6 months ago

No, that integration was on my side within Apoth here https://github.com/Shadows-of-Fire/Apotheosis/blob/1.20/src/main/java/dev/shadowsoffire/apotheosis/mixin/client/AttributeTooltipsMixin.java

Lucky-56 commented 6 months ago

so this would get fixed if

  1. I installed Apoth aswell
  2. and you got it fixed?

since the issue right now is just attributeslib