Shadows-of-Fire / FastWorkbench

Caching recipes in the crafting table
MIT License
23 stars 17 forks source link

Craftings a satck with FastWorkbench is still lot slower than with Tinker Crafting Station. #12

Closed Fireztonez closed 5 years ago

Fireztonez commented 5 years ago

Hello, I just make somes tests recently in my modpack, and I fond the fact of when I used FastWorkbench Crafting table or a supported Modded Crafting Table, the craft look a lot slower than when I use Tinker the Crafting Station, when you craft a complete stack at the time... The bigger difference is with a recipe with a giveback, but it's also notifiable with simple vanilla recipe like 3 wheat to make bread...

I wonder if you can look question to optimized a littlebit more or do something for when you craft 1 stack at the time... For what I saw, the Tinker Crafting Station craft directly 1 stack, in 1 operation, so there have no delay between each one, but, FastWorkbench Crafting Table still craft 1 at the time, for finally give you a complete stack, so it probably execute 64x the crafting operation (Because I notice 4 or 5 of the output appear in my inventory before it finish all the crafts and the complete stack appear in my inventory).

I have make a video for you to show the difference: https://streamable.com/9s5m1

Version: Minecraft: 1.12.2 Forge: 14.23.5.2824 FastWorkbench: 1.6.1 TConstruct: 2.12.0.135

Thank's Fireztonez

Fireztonez commented 5 years ago

Your fix work's pretty good for all normal recipe, this is perfect! Only recipe a thing how rest in crafting table or is transformDamage can possibly be optimize a bit, but like you say, this is still experimental and this is more complexe to do something for craft like in my video, how an item stay in the crafting table or recipe damage for each craft, and this affect only few recipes... Thank you very mutch Shadows-of-Fire!

I try with the Crafting Table on a Stick from AA, Handheld Crafting Table from Extended Crafting Table and the 3x3 inventory crafting tabel from cyclic, both look to work with your new improvement!!

Continue your great job and tank-you very mutch for doing that!