Shadows-of-Fire / FastWorkbench

Caching recipes in the crafting table
MIT License
23 stars 17 forks source link

Remove the need for a block #20

Closed T145 closed 5 years ago

T145 commented 5 years ago

This update simply overrides the workbench interaction, instead of creating a whole other block. The minor container change will also let other mods open this mod's GUI from their blocks & get a "ContainerFix" benefit w/out having to extend the workbench directly.

Side note: I noticed the container gets called twice client side w/ this method. Haven't tested the unchanged code to see if it only happens once in that context.

Shadows-of-Fire commented 5 years ago

I simply don't like this model. Why are you trying to push these changes anyway? Perhaps there is another solution.

T145 commented 5 years ago

What's not to like about it? You can remove the whole block. My ultimate desire is to completely replace any open crafting container with yours real-time. This way no one needs to copy-paste your code around, or add compatibility manually.

Shadows-of-Fire commented 5 years ago

Messing with containers is a very fragile act. It has the potential to break a ton of things. This is why mods that require FB support implement it directly. People making custom crafting tables shouldn't be using vanilla anyway due to it's flaws.