search

Shadows-of-Fire / Foundry

Minecraft mod that adds liquid metals
GNU Lesser General Public License v3.0
5 stars 3 forks source link

Unable to remove certain melting recipes w/ CrT #17

Closed Matryoshika closed 6 years ago

Matryoshika commented 6 years ago

Foundry: 3.1.1.0 Forge: 14.23.2.2615 CraftTweaker Script: https://pastebin.com/XpuTb2WD

What is expected to happen: Each ore is removed from Foundry's Melting recipe manager, and another recipe with different amount is re-added.

What happens: For some ores, removeRecipe errors and logs Melting recipe not found. Most other ores are unaffected. These ores retain their original recipe, and stays in JEI.

All affected ores do have an OreDict value (oreNether & oreEnd) Affected mods: Nether Metals, End Metals, OreCore Issue happens with and without the IItemStacks being in arrays (and normal non-loop removeRecipes for these ores are also affected). The removeRecipes at lines 5-13 are unaffected by this, and function properly.

Shadows-of-Fire commented 6 years ago

This nonsense happens because Foundry copies every TiC recipe it has to its own recipe managers. This happens after scripts are run on Foundry's end. The Metals* set only has integration for TiC, so foundry was finding them and copying them after it ran the scripts. This build should work with that script, as I moved the CT integration to run last, but I'm busy and can't test it.

Matryoshika commented 6 years ago

Sadly, no discernable difference with the new build. Same outcome as before.

Shadows-of-Fire commented 6 years ago

Alright. I see what's wrong with it. For whatever reason Nether/End metals registers their items under the wildcard meta (these blocks don't even have meta, jas why tho) and Foundry isn't accounting for that meta being in use here. Had to dump the entire melting registry to figure that out. Fix soonish.