search

Shadows-of-Fire / Foundry

Minecraft mod that adds liquid metals
GNU Lesser General Public License v3.0
5 stars 3 forks source link

Crash with Botania's Exoflame and foundrys alloy furnace #34

Closed scalda closed 6 years ago

scalda commented 6 years ago

Hi I am posting this here along with on botania's page.

In Foolcraft 3 we have found a crash to desktop crash on placing an alloy furnace within range of a botania ExoFlame flower. Please find the Crash report here

Foundry: Foundry-1.12.2-3.2.0 Botania: Botania r1.10-354 Forge: 14.23.4.2739

https://github.com/scalda/Foolcraft_3/issues/179

quat1024 commented 6 years ago

Likely caused by https://github.com/Shadows-of-Fire/Foundry/blob/5a9970dfd07863d64aed3dc58ce44ad170b92b1e/src/main/java/exter/foundry/tileentity/TileEntityAlloyFurnace.java#L101

Botania's mod ID is botania not Botania, causing this method to errantly get stripped

Shadows-of-Fire commented 6 years ago

Quality legacy codebase. Bleh.

quat1024 commented 6 years ago

just a quick find-and-replace Botania -> botania fixes the crash, but the mod integration doesn't seem to actually work haha

I'll investigate and open a pr

edit: The bug is TileEntityAlloyFurnace line 104, which has some messed up logic in it, it looks for only the first itemstack to be nonempty

Shadows-of-Fire commented 6 years ago

I can get it. I'm gonna make that system a bit better overall anyway.

quat1024 commented 6 years ago

Damn i was 2 slow