search

Shadows-of-Fire / PackMenu

Tool for editing the main menu in modpacks.
MIT License
15 stars 10 forks source link

Really weird nether panorama shows up sometimes when my custom modpack is loaded. I have zero clue what is causing this, all my pack menu files seem like they are correct #27

Closed JkubCC closed 2 years ago

JkubCC commented 3 years ago

2021-04-16_13 59 02

JkubCC commented 3 years ago

2021-04-22_00 03 50

This is what the menu is supposed to look like, there is also music aswell. Id say about 50% of the time the bugged out panorama shows up

ReeCodes commented 3 years ago

SAME!

Raft08 commented 2 years ago

Do you have maybe try to delete config? it can help

Shadows-of-Fire commented 2 years ago

That's the vanilla panorama. I've never been able to reproduce it reliably, so I think it's some sort of race condition.

What I think happens is, based on mod loading times, sometimes this doesn't execute before the texture manager preloads all the panorama textures https://github.com/Shadows-of-Fire/PackMenu/blob/1.18/src/main/java/shadows/menu/PackMenuClient.java#L49

Might be able to fix it with a mixin

Shadows-of-Fire commented 2 years ago

Should... maybe be fixed 4.1.0 (1.18.2), if it still persists reopen this.