search

Shadows-of-Fire / Placebo

A library mod
MIT License
23 stars 22 forks source link

Add compatibility for the mod Lootr. #19

Closed noobanidus closed 3 years ago

noobanidus commented 3 years ago

Lootr hooks primarily off of LockableLootTileEntity's static setLootTable method as the member method doesn't contain the correct world for replacement. Attempts to hook off the latter generally require weird magic.

Functionally this is identical, although in your use-case it's slightly more cumbersome visually.

Unfortunateley the second constructor does become slightly problematic. I'm not sure how much this is used throughout your mods, so I've supported both instances.

I may also be insane.

Disclaimer: I wasn't able to fully test it because I can't get Placebo to compile due to dependency issues.

Shadows-of-Fire commented 3 years ago

I will get to this eventually™ when things calm down

noobanidus commented 3 years ago

No stress!