Shadows-of-Fire / Shadows-of-Greg

An addon for GregTech Community Edition with the goal of making it much more complicated and realistic through the use of GregTech 5 Unofficial and GregTech 6 features.
GNU General Public License v3.0
16 stars 30 forks source link

Cleanup of Recipes and moving to RecipeHandlers #141

Open ALongStringOfNumbers opened 3 years ago

ALongStringOfNumbers commented 3 years ago

This PR cleans up various recipe removals and additions, where recipes are removed and then a duplicate recipe is added.

In addition, this PR refactors crafting table recipe removals, namely through wrapping the previously used GTCE methods so that we can add additional logging to see if a removal has failed.

GAConfig

GAEnums

GregicAdditions

GAMetaItems

GAMetaTool

ComponentRegistration

GAMachineRecipeRemoval

GARecipeAddition

GeneratorFuels

MachineCraftingRecipes

MatterReplication

RecipeHandlers

Process Ingot

This handles the expensive Wrenches and creating recipes for the Bending Cylinders, both config based

Process Tiny Dust

Changes Tiny dusts to be made using the schematic instead of the integrated circuit

Process Small Dust

Changes Small dusts to be made using the schematic instead of the integrated circuit

Process Foil

Adds recipes for handcrafting foils and Cluster Milling foils, both config based

Process Ring

Changes the Ring Recipes to use the Bending Cylinder, config based

Process Round

Adds hand crafting and lathe recipes for the round

Process Plate Curved

Add recipes converting from plates to curved plates, and vice versa, for both hand crafting and the bender Registers Recipes for pipes using curved plates (Adds handcrafting recipes for Tiny and Large pipes, which did not have them in base GTCE) Registers Recipes for Rotors with curved plates (by hand and machine), or else restores the rotor assembler recipes removed by GTCE

Process Double Ingot

Adds recipes for Double Ingots and Double Ingots to plates

Process Plate

Adds handcrafting recipes for Tiny and Large pipes (similar to what is done with curved plates), when curved plates are not enabled

Process Wire GT

Adds Bundler recipes Adds the GT5U cable recipes (Which is a big mess)

Process Gems

HelperMethods

This class currently just wraps the GTCE removal methods so that we can attach logging to the removals. When I am done testing this PR, the logging levels will be moved to debug on pass and warn on fail.

Closes #144

A Note of conversation. The double ingots flag and config option currently will generate recipes for plates that normally do not have recipes, due to the NO_SMASHING flag. Do we want to add this flag to Double ingot generation, to prevent these materials from being generated, or to the crafting recipes, to prevent the hand crafting recipes from being generated? This is a break from previous behavior, but it does make some sense.