search

ShadowsocksR-Live / shadowsocksr-native

翻墙 从容穿越党国敏感日 ShadowsocksR (SSRoT) native implementation for all platforms, GFW terminator
https://github.com/ShadowsocksR-Live/shadowsocksr-native/wiki
GNU General Public License v3.0
2.74k stars 763 forks source link

CMakeLists.txt: change install from absolute path to relative path #99

Closed Vonfry closed 4 years ago

Vonfry commented 4 years ago

Please answer these questions before submitting your issue. Thanks!

What version of shadowsocks-native are you using?

HEAD

What operating system are you using?

NixOS

What did you do?

write a nix expression to build it on nixos

What did you expect to see?

build success

What did you see instead?

error when installing.

The reason is in the CMakeLists.txt, e.g. https://github.com/ShadowsocksR-Live/shadowsocksr-native/blob/master/src/CMakeLists.txt#L241-L245. It codes install with absolute path, which make CMAKE_INSTALL_PREFIX not working. I suggest change it to a relative path, make the install phase more compatible.

ssrlive commented 4 years ago

We just want to keep things simple. Our target users are ordinary people, not all programmers. So we don't want to add complexity.

Vonfry commented 4 years ago

Right, just advice. I can make a patch for myself to let it run.

ssrlive commented 4 years ago

well, you can commit a PR, and add a cmake parameter in the same time in install.sh file.