ShaftHQ / SHAFT_ENGINE

SHAFT is a unified test automation engine for web, mobile, API, CLI, database, and desktop e2e testing. Powered by best-in-class frameworks, SHAFT provides a wizard-like syntax to drive your automation efficiently, maximize your ROI, and minimize your learning curve with no limitations! Stop reinventing the wheel! Upgrade now!
https://shafthq.github.io/
MIT License
324 stars 123 forks source link

Fix: Ensure query parameters are added to requests with a body #1632

Closed KyrillosNageh closed 3 months ago

KyrillosNageh commented 3 months ago

This pull request fixes a bug where query parameters were not being added to requests that also have a body. It improves the performRequest method to ensure query parameters are correctly appended to the URL, along with enhancing error handling and modularizing the code.

- Problem: When making HTTP requests with both query parameters and a request body, the query parameters were ignored, resulting in incorrect request URLs.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.59%. Comparing base (a90d639) to head (7b718a4). Report is 34 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1632 +/- ## ============================================= - Coverage 54.32% 39.59% -14.73% + Complexity 1377 971 -406 ============================================= Files 111 113 +2 Lines 9966 10139 +173 Branches 966 974 +8 ============================================= - Hits 5414 4015 -1399 - Misses 3941 5523 +1582 + Partials 611 601 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MohabMohie commented 3 months ago

I think you need to rebase this against the master branch my friend. There are several commits in the PR and 600+ changed files.

Kindly close this PR, clean up the branch, and open a new one so that I can see the actual changes.