Closed KyrillosNageh closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 39.59%. Comparing base (
a90d639
) to head (7b718a4
). Report is 34 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think you need to rebase this against the master branch my friend. There are several commits in the PR and 600+ changed files.
Kindly close this PR, clean up the branch, and open a new one so that I can see the actual changes.
This pull request fixes a bug where query parameters were not being added to requests that also have a body. It improves the performRequest method to ensure query parameters are correctly appended to the URL, along with enhancing error handling and modularizing the code.
- Problem: When making HTTP requests with both query parameters and a request body, the query parameters were ignored, resulting in incorrect request URLs.
Solution: Dynamic URL Construction: Added functionality to append query parameters to the request URL, ensuring they are not lost when a body is present. Comprehensive Error Management: Improved exception handling to manage errors during the request process effectively. Modular Helper Methods: Created helper methods to append query parameters, check supported request types, and handle exceptions.
Linked Issue: Fixes #1615