ShaftHQ / SHAFT_ENGINE

SHAFT is a unified test automation engine for web, mobile, API, CLI, database, and desktop e2e testing. Powered by best-in-class frameworks, SHAFT provides a wizard-like syntax to drive your automation efficiently, maximize your ROI, and minimize your learning curve with no limitations! Stop reinventing the wheel! Upgrade now!
https://shafthq.github.io/
MIT License
330 stars 127 forks source link

[Bug]: BrowserStack Session Name display device name instead of build name && Status is TIMED OUT aleady regardless of PASSED/FAILED. #1727

Closed Ashraf-Ali-gathern closed 1 month ago

Ashraf-Ali-gathern commented 1 month ago

Describe the bug

shaft with BrowserStack Session Name display device name instead of build name && Status is TIMED OUT aleady regardless of PASSED/FAILED.

Link to SHAFT_Engine Prject

Screenshots

2

MohabMohie commented 1 month ago

Regarding the first issue from the post:

examining the attached project shows that there is no proper teardown for the driver. you need to call driver.quit(); in your @AfterMethod or @AfterClass annotation to avoid the timeout in browserstack.

Regarding the second issue: session name is generated automatically by browserstack, SHAFT only sets the project name and build name as per this code: https://github.com/ShaftHQ/SHAFT_ENGINE/blob/4e4041b8b0c5839ec6b748960c5f92831d931c4d/src/main/java/com/shaft/driver/internal/DriverFactory/BrowserStackHelper.java#L218

if you would like to extend this behavior kindly mention exactly what you want to happen and let's discuss in a new feature request.

I'll be closing this bug for now since it's not really valid.