search

ShaggyTech / nhtsa-api-wrapper

Decode and Validate Vehicle VINs - Javascript Client Wrapper for the nhtsa.dot.gov VPIC Vehicles API.
https://vpic.shaggytech.com
MIT License
30 stars 8 forks source link

fix(coverage): rename folder alias for .vitest folder to '.vitest' #519

Closed ShaggyTech closed 1 year ago

ShaggyTech commented 1 year ago

Resolves Issue #515

The import alias for packages/lib/.vitest folder was previously named @vitest. This was conflicting with package dependencies that start with "@vitest" such as @vitest/coverage-c8 which in turn caused failure of coverage reports.

Renamed the alias to actual folder name (.vitest) and coverage is now reported correctly.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: f2f55e1fe15b087b1d10f9e79241b177ca2aad2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nhtsa-api-wrapper ✅ Ready (Inspect) Visit Preview Apr 17, 2023 2:27am
codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@b6216c0). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #519 +/- ## ======================================= Coverage ? 99.17% ======================================= Files ? 35 Lines ? 4260 Branches ? 282 ======================================= Hits ? 4225 Misses ? 35 Partials ? 0 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Eichler). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Brandon+Eichler)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.