Shahabks / myprosody

A Python library for measuring the acoustic features of speech (simultaneous speech, high entropy) compared to ones of native speech.
https://shahabks.github.io/myprosody/
MIT License
232 stars 63 forks source link

Refactoring and adding documentation #5

Closed antoninklopp closed 4 years ago

antoninklopp commented 5 years ago

Hi,

In order to augment maintainability and understanding for others, I refactored the part where the praat file runs and added the documentation of the EXAMPLES files as function doc in the code.

Shahabks commented 5 years ago

Hello Antonin, You are most welcome. I hope the library works for you after our discussion here. You need to install pickle if you wish to use "SpeechRater" or evaluating spoken language prosody, pronunciation, structures of an audio file.......It is because those some functions, such as "mysplev", were developed based on machine learning algorithms.

the function "mysplev" does not work for you either you have not installed the pickle library on your virtual environment your machine is not compatible with the version of ML algorithm that I developed.......In this case you need to train the ML models (Acoustic and language models) on your machine (my previous experience with another user of Myprosody) if you download or clone https://github.com/Shahabks/myprosody/tree/master/myprosody/dataset from my github, please remember to follow these steps unzipped the downloaded directory extract the directory inside (copy and paste) on your desktop or wherever you wish on your machine. THE PATH to the DIRECTORY SHOULD BE " / wherever you save /myprosody /......for example (c:/users/your name/desktop/myprosody/ IN THE directory MYPROSODY you should have now / -------- /myprosody /dataset/audioFiles/ where you save your audio files ............ for example (c:/users/your name/desktop/myprosody/ dataset/audioFiles/ IN THE directory MYPROSODY you should have now / -------- /myprosody /dataset/ essen/ where you save all models already available in essen folder from my Github Please let me know if you run again in any issue Kind regards Shahab

antoninklopp commented 5 years ago

Hi,

Thanks for answering my Issue #4 . However, I am here suggesting changes to your code (that you might accept or not) and not running into an issue !

Shahabks commented 5 years ago

Thank you for your suggestion .....surely being considered and I appreciate your view

On Sun, 21 Jul 2019 at 22:35, Antonin KLOPP-TOSSER notifications@github.com wrote:

Hi,

Thanks for answering my Issue #4 https://github.com/Shahabks/myprosody/issues/4 . However, I am here suggesting changes to your code (that you might accept or not) and not running into an issue !

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Shahabks/myprosody/pull/5?email_source=notifications&email_token=AGTX33VOVGQJAUAU33WVFMLQARQZBA5CNFSM4IFRYA32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2ODV6A#issuecomment-513555192, or mute the thread https://github.com/notifications/unsubscribe-auth/AGTX33R24VNOUPKV5D47RW3QARQZBANCNFSM4IFRYA3Q .