search

ShaharMS / Vision

Cross framework, cross platform computer vision for Haxe
MIT License
35 stars 5 forks source link

Fixed `faster-simple-line-detector` #27

Closed Wither362 closed 2 years ago

Wither362 commented 2 years ago

IT WORKSSS!! @ShaharMS!! It compiles correctly!!

ShaharMS commented 2 years ago

Why is CI failing like that?

ShaharMS commented 2 years ago

Btw, the whole thing getUnsafePixel does is being a bit faster by not doing null/bound checking. OutsideBounds error usually means a getUnsafePixel call gone wrong.

Wither362 commented 2 years ago

Oh, thanks

ShaharMS commented 2 years ago

Also, why not just test yourself if you're getting the error? Testing on interp is the fastest thing to do for problems like this one

Wither362 commented 2 years ago

Also, why not just test yourself if you're getting the error? Testing on interp is the fastest thing to do for problems like this one

Because I’m at school :'(, and I’m using the tablet

ShaharMS commented 2 years ago

Oh wow, nice :D

Wither362 commented 2 years ago

Sorry for the notifications, if you don’t want notifications from this pull request, click here: notificati9n inage

ShaharMS commented 2 years ago

Nah it's fine, I think it's better seeing the progress. Feel free to ask me anything:)

Wither362 commented 2 years ago

IT WORKS!