search

ShaharMS / spacebubble.io

my website, in which im gonna put my apps, library docs and more things ill think about :)
3 stars 0 forks source link

`section`s on the main website page are not dynamic, and only work correctly under the `body` tag #1

Closed ShaharMS closed 2 years ago

ShaharMS commented 2 years ago

Where?

on line 12, 13 in ./styles.css

body section {
    /*...*/
    width: 100vw;
    height: 100vh;

Issue

setting the width and height with vh and vw instead of % makes this setup work incorrectly under everything that isn't intended to be the size of the screen.

Also, using view-port measurements for the sections allows a slight horizontal scroll, which is annoying to look at (and drops page rank)

ShaharMS commented 2 years ago

turns out the only needed change is for the height property. anyway, this is fixed