Closed avi-l closed 5 months ago
Great Job @avi-l It seems you resolved two issues in one go. Much Appreciated!.
Heh, had no choice, had crazy behavior running the app without fixing that first. Glad to help.
On Wed, Jan 31, 2024, 14:25 Shaik Shahbaaz Alam @.***> wrote:
Great Job @avi-l https://github.com/avi-l It seems you resolved two issues in one go. Much Appreciated!.
— Reply to this email directly, view it on GitHub https://github.com/ShahbaazX786/tracker.io/pull/16#issuecomment-1919006970, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQHF5MOXTLBN5DY7YIZ7WLDYRIZ3XAVCNFSM6AAAAABCS4XGTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJZGAYDMOJXGA . You are receiving this because you were mentioned.Message ID: @.***>
I relied upon next-themes built in dark mode theme provider so as to not have to write one to work with radix-ui theme. It's difficult to manage this kind of state in SSR, this was the easy solution, but now we've got a Theme inside of a Theme, so if you're not cool with that, I understand, but I saw another issue where you're thinking of changing your UI anyway (i suggest shadcn, which is where this next-themes dark mode provider comes from.. https://ui.shadcn.com/docs/dark-mode/next )