ShahriyarR / MySQL-AutoXtraBackup

MySQL-AutoXtraBackup commandline tool written in Python 3 based on Percona XtraBackup

https://autoxtrabackup.azepug.az/

MIT License

140 stars 79 forks source link

[List] Small improvements to config file #340

Closed BarbzYHOOL closed 5 years ago

BarbzYHOOL commented 5 years ago

This issue can be seen as a list of small improvements that can be made to the config file, to make it more practical to use and easy to manipulate. Feel free to add to it by commenting or directly editing my issue (for repo members):

RENAMING

Variable names:

[ ] max_archive_size --> archive_max_size
[ ] max_archive_duration --> archive_max_duration
[ ] backupdir --> backup_dir
[ ] tmpdir --> tmp_dir
[ ] datadir --> data_dir

Comments:

[ ] #use either socket or port + host combination --> ## Set either mysql_socket only, OR host + port. If both are set mysql_socket is used

STRUCTURING

[ ] Maybe group all the optional variables together? (I personally did that for clarity)
[ ] Move the [TestConf] part to another file? or do not even include it? Seems rather useless for normal folks like me

ShahriyarR commented 5 years ago

[TestConf] already removed from default config file in release_v1.5.4 branch. It seems to be all mentioned improvements are valid and I will make it available soon. But grouping together all optional things can be problematic and confusing to the end user the best is to leave it alone. Thank you very much for such awesome community support :)

ShahriyarR commented 5 years ago

Okay I am going to close other issues such as:

327 and #337

Everything mentioned in those issues will be implemented as part of this fix.

ShahriyarR commented 5 years ago

datadir will remain as datadir not data_dir because it is MySQL side variable and should stay as original:

mysql> select @@datadir;
+-----------------+
| @@datadir       |
+-----------------+
| /var/lib/mysql/ |
+-----------------+
1 row in set (0.00 sec)

ShahriyarR commented 5 years ago

@BarbzYHOOL I have implemented bunch of your proposals. Could you please check them - the branch is release_v1.5.4

ShahriyarR commented 5 years ago

It seems to be I can freeze this and merge to master to release new version. Thank you for your reports, ideas. The Open Source history will not forget you.